[auth] Improve whoami #1693
Merged
[auth] Improve whoami #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
reviewed
Dec 22, 2023
| @@ -119,15 +120,14 @@ func handleError(stderr *bytes.Buffer, err error) error { | |||
| return errors.WithStack(err) | |||
| } | |||
|
|
|||
| func DefaultEnvsec(stderr io.Writer, workingDir string) *envsec.Envsec { | |||
| func DefaultEnvsec(stderr io.Writer) *envsec.Envsec { | |||
There was a problem hiding this comment.
Given that most uses of this function are setting WorkingDir, I feel we should preserve the parameter. Otherwise, its very easy to overlook or forget it needs to be set.
Can we pass in an empty-value for the "WhoAmI" use-case?
savil
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TSIA
How was it tested?