[envsec] Ensure build environment is the same #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savil
approved these changes
Jan 5, 2024
| @@ -40,16 +41,20 @@ func (d *Devbox) addDevboxUtilityPackage(ctx context.Context, pkg string) error | |||
| // process-compose, etc | |||
| func (d *Devbox) addUtilitiesToPath( | |||
| ctx context.Context, | |||
| path string, | |||
| ) (string, error) { | |||
| env map[string]string, | |||
There was a problem hiding this comment.
update the function comment to match the new function name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is combined with jetify-com/opensource#251 to ensure devbox and envsec environments are always the same.
Otherwise, when using dev devbox, it will install a prod envsec and environments won't match which causes issues because dev environment uses a different authentication issuer so keys are not compatible.
How was it tested?