Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue introduced in #1709
devbox run
usessh
instead of native shell. So init hooks must always besh
compatible forrun
. On the other hand,devbox shell
uses native shell so init hooks must befish
if the native shell is fish.This is ugly, but it's how it has always worked.
#1709 introduced recursion protection that would be
fish
orsh
depending on native shell. This worked fine fordevbox shell
but would breakdevbox run
.This change fixes that by creating 2 hooks files, one fish and one sh and sourcing the correct one in shellrc, while still always using the
sh
for run.cc: @Lagoja
How was it tested?