Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fish] use fish hooks file for devbox.EnvExports (used in shellenv) #1756

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

savil
Copy link
Collaborator

@savil savil commented Jan 26, 2024

Summary

I was getting shell script parsing errors when doing
devbox global shellenv --init-hook | source
in fish

Turns out, we were sourcing the init-hook file for non-fish. This PR fixes that

How was it tested?

Ran the above command succesfully in a fish shell

Copy link
Collaborator Author

savil commented Jan 26, 2024

@savil savil requested a review from mikeland73 January 26, 2024 23:27
@savil savil force-pushed the savil/fish-shellenv-init-hooks branch from fd639cb to 78ae686 Compare January 27, 2024 01:30
Base automatically changed from savil/shell-init-hook-fish-fix to main January 27, 2024 01:35
@savil savil force-pushed the savil/fish-shellenv-init-hooks branch from 78ae686 to f55920a Compare January 29, 2024 16:52
@savil savil requested review from gcurtis and ipince January 29, 2024 19:40
@savil savil force-pushed the savil/fish-shellenv-init-hooks branch from f55920a to 2a8abb6 Compare January 30, 2024 18:28
@savil savil merged commit 7796d01 into main Jan 30, 2024
23 checks passed
@savil savil deleted the savil/fish-shellenv-init-hooks branch January 30, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants