Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/switch pip plugin reference to python #2265

Merged

Conversation

djgoku
Copy link
Contributor

@djgoku djgoku commented Sep 12, 2024

Summary

Remove pip plugin and use Python plugin.

How was it tested?

devbox run lint
devbox run test
go mod tidy
devbox shell testing new python plugin (cp plugins/python.json plugins/plugin.json and add "include": ["path:./plugins/"], to devbox.json. Though this is the output I got (not the Poetry message):

devbox % ./dist/devbox shell                       
Info: Ensuring packages are installed.
✓ Computed the Devbox environment.
Starting a devbox shell...
Virtual environment directory doesn't exist. Creating new one...

Poetry could not find a pyproject.toml file in /Users/dj_goku/dev/github/djgoku/devbox or its parents

@savil savil requested a review from Lagoja September 12, 2024 03:04
```
% devbox add pip

Error: Package pip not found
```

we also moved `venvShellHook.sh` to a python directory.
@djgoku djgoku force-pushed the chore/switch-pip-plugin-reference-to-python branch from 102e590 to b697a63 Compare September 12, 2024 13:41
@Lagoja
Copy link
Contributor

Lagoja commented Sep 12, 2024

Made two small tweaks:

  1. Updated the packages listed in the docs snippet
  2. I found a bug in how the UV_PYTHON variable was set, I so I changed that as well

@Lagoja Lagoja merged commit df187b9 into jetify-com:main Sep 12, 2024
24 checks passed
@djgoku djgoku deleted the chore/switch-pip-plugin-reference-to-python branch September 12, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants