patchpkg: don't error on missing store refs #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't exit non-zero when `devbox patch` is unable to restore some of the missing references to Python build dependencies. Fixes #2289.
mikeland73
approved these changes
Sep 23, 2024
savil
approved these changes
Sep 23, 2024
| // Don't break the flake build if we're unable to | ||
| // restore some of the refs. Having some is still an | ||
| // improvement. | ||
| slog.ErrorContext(ctx, "unable to restore all removed refs", "err", err) |
There was a problem hiding this comment.
any insight into the possible causes for why we're unable to restore some of the refs?
There was a problem hiding this comment.
Not entirely sure. It finds missing refs by searching for the package name (in this case llvm-16.0.6) in the buildInputs dependency tree of Python. Finding the packages this way is really just a heuristic, so it's not implausible that we miss something.
Right, I just enabled them by default when I added another test for this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't exit non-zero when
devbox patchis unable to restore some of the missing references to Python build dependencies.Fixes #2289.