Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugins] Add env var to control github cache ttl #2314

Merged
merged 1 commit into from
Oct 1, 2024
Merged

[plugins] Add env var to control github cache ttl #2314

merged 1 commit into from
Oct 1, 2024

Conversation

mikeland73
Copy link
Contributor

Summary

This adds new experimental env var DEVBOX_X_GITHUB_PLUGIN_CACHE_TTL that controls how long devbox caches github plugins. The default is 24h.

Ideally we store plugin versions in lockfile, but this can help improve UX in the meantime.

How was it tested?

Added print statement to monitor network requests

DEVBOX_X_GITHUB_PLUGIN_CACHE_TTL=0 devbox run echo hello
DEVBOX_X_GITHUB_PLUGIN_CACHE_TTL=1s devbox run echo hello
DEVBOX_X_GITHUB_PLUGIN_CACHE_TTL=1h devbox run echo hello

@mikeland73 mikeland73 requested review from gcurtis and savil October 1, 2024 00:04
@mikeland73 mikeland73 merged commit fc7a398 into main Oct 1, 2024
29 checks passed
@mikeland73 mikeland73 deleted the landau/add-cache-ttl branch October 1, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@savil savil savil approved these changes

@gcurtis gcurtis Awaiting requested review from gcurtis

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeland73 @savil