Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth] Fix failed session refresh #2350

Merged
merged 1 commit into from
Oct 12, 2024
Merged

[auth] Fix failed session refresh #2350

merged 1 commit into from
Oct 12, 2024
+26 −2

Conversation

mikeland73
Copy link
Contributor

Summary

If refresh fails, we should tell user to log in again instead of showing weird invalid_grant error

How was it tested?

  • messed with refresh token to make it bad.
  • Set expiration date in my session to date in past.
  • Did devbox auth whoami

@mikeland73 mikeland73 requested review from gcurtis and savil October 11, 2024 22:49
@mikeland73 mikeland73 merged commit 5bf73ed into main Oct 12, 2024
29 checks passed
@mikeland73 mikeland73 deleted the landau/fix-failed-refresh-token branch October 12, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucilleH LucilleH LucilleH approved these changes

@gcurtis gcurtis Awaiting requested review from gcurtis

@savil savil Awaiting requested review from savil

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeland73 @LucilleH