Skip to content

Commit

Permalink
Remove hardcoded smarthop related fields DEV-1227 (#19)
Browse files Browse the repository at this point in the history
## Summary
Remove hardcoded smarthop related fields. Is it safe to remove?

## How was it tested?
launchpad up

## Is this change backwards-compatible?
yes-ish
  • Loading branch information
LucilleH authored Nov 15, 2022
1 parent be16477 commit 64632ec
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 68 deletions.
7 changes: 1 addition & 6 deletions padcli/helm/helm.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,16 +176,11 @@ func (hvc *ValueComputer) Compute(ctx context.Context) error {
}

func (hvc *ValueComputer) ComputeHostname(ctx context.Context) (string, error) {
appFragment := ""
// Hack so we don't break old Smarthop URLs.
if hvc.cluster.GetHostname() == "smarthop.jetpack.dev" {
appFragment = "-app"
}
websvc, err := hvc.jetCfg.WebService()
if err != nil {
return "", errors.WithStack(err)
}
hostname := websvc.GetName() + appFragment + "-" + hvc.namespace + "." + hvc.cluster.GetHostname()
hostname := websvc.GetName() + "-" + hvc.namespace + "." + hvc.cluster.GetHostname()
url, err := websvc.GetURL()
if err != nil {
return "", errors.Wrap(err, "unable to get web service url")
Expand Down
62 changes: 0 additions & 62 deletions pkg/jetcloud/jetgcp/auth.go

This file was deleted.

0 comments on commit 64632ec

Please sign in to comment.