Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Readme #21

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Update Readme #21

merged 3 commits into from
Nov 15, 2022

Conversation

LucilleH
Copy link
Collaborator

Summary

Update Readme

How was it tested?

Github markdown preview

Is this change backwards-compatible?

Yes

Signed-off-by: Lucille Hua <lucille.hua@jetpack.io>
@LucilleH LucilleH requested a review from Lagoja November 14, 2022 22:50
Signed-off-by: Lucille Hua <lucille.hua@jetpack.io>
README.md Outdated

`launchpad help` - see all commands

`launchpad env` - use launchpad's secret management toolchain
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we flag some as Mission Control required?

Copy link
Collaborator Author

@LucilleH LucilleH Nov 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. I'm thinking people don't really know what Mission Control really is, so that information may not be helpful. I can say, login required maybe?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's do that instead. Otherwise LGTM

Signed-off-by: Lucille Hua <lucille.hua@jetpack.io>
@LucilleH LucilleH merged commit 745b355 into main Nov 15, 2022
@LucilleH LucilleH deleted the lucille--update-readme branch November 15, 2022 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants