Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[envsec] Don't require git repo #226

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

mikeland73
Copy link
Contributor

Summary

TSIA

In a follow up, I'll improve project name when not in github repo.

How was it tested?

envsec init (not in repo)

@mikeland73 mikeland73 requested review from loreto and savil December 14, 2023 19:14
Copy link
Contributor

@loreto loreto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ... although once this is in, I have two questions:

  1. How will GetOrCreate work? I thought the name of the repo is a key parameter to it
  2. Will we add the "link" functionality? Or rather: in a different computer how do I associate a directory with an existing project that has no git repo?

@mikeland73
Copy link
Contributor Author

@loreto I was thinking of a prompt that allows user to pick an existing project or create a new one. Something like

envsec init
* project 1
* project 2
* project 3
* Create new project

Something along those lines.

So we may not end up needing GetOrCreate TBD

@mikeland73 mikeland73 merged commit f3023c6 into main Dec 14, 2023
1 check passed
@mikeland73 mikeland73 deleted the landau/dont-require-repo branch December 14, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants