[JetpackAPIStore] use apiClient #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
savil
force-pushed
the
savil/envsec-api-store-client
branch
from
9d369ff to
6d65761
Compare
mikeland73
approved these changes
Dec 20, 2023
envsec/jetpack_api_store.go
Outdated
| } | ||
|
|
||
| // JetpackAPIStore implements interface Store (compile-time check) | ||
| var _ Store = (*JetpackAPIStore)(nil) | ||
|
|
||
| func newJetpackAPIStore(config *JetpackAPIConfig) *JetpackAPIStore { | ||
| return &JetpackAPIStore{config: config} | ||
| return &JetpackAPIStore{ | ||
| client: api.NewClient(context.Background(), config.host, config.token).SecretsService(), |
There was a problem hiding this comment.
good catch! my copy-pasta bad
savil
force-pushed
the
savil/envsec-api-store-client
branch
from
6d65761 to
ce2f781
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This uses the new
apiClient, which has the benefit of managing the Authorizationheader from the token, as well as creating the SecretsService client just once.
I chose to avoid re-defining the SecretsService's methods again. Would prefer
benefitting from the codegen we get and directly using that.
How was it tested?
envsec lsandenvsec setwork as before