Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[envsec] Use survey intead of promptui #248

Merged
merged 3 commits into from
Jan 4, 2024
Merged

[envsec] Use survey intead of promptui #248

merged 3 commits into from
Jan 4, 2024

Conversation

mikeland73
Copy link
Contributor

Summary

Replace promptui with survey. Survey is archived but more recently used. It seems more stable. Other option is https://github.com/charmbracelet/huh but it is very large.

Removed repo/dir from prompt to make lines more readable. See https://jetpack-io.slack.com/archives/C05NSEPE21H/p1704327292057999

How was it tested?

image

@mikeland73 mikeland73 requested review from loreto and LucilleH January 4, 2024 00:19
@mikeland73 mikeland73 changed the title Landau/init survey [envsec] Use survey intead of promptui Jan 4, 2024
LucilleH
LucilleH approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@LucilleH LucilleH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like survey better 👍

@mikeland73 mikeland73 merged commit 4997606 into main Jan 4, 2024
1 check passed
@mikeland73 mikeland73 deleted the landau/init-survey branch January 4, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucilleH LucilleH LucilleH approved these changes

@loreto loreto Awaiting requested review from loreto

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeland73 @LucilleH