[brand] Update jetpack.io -> jetify #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeland73
commented
Apr 15, 2024
| @@ -33,7 +33,7 @@ func Issuer() string { | |||
| } | |||
|
|
|||
| func Audience() string { | |||
| return "https://api.jetpack.io" | |||
| return "https://api.jetify.com" | |||
There was a problem hiding this comment.
We are currently supporting both audiences so this is backwards compatible.
There was a problem hiding this comment.
You sure? Do we need to change Ory?
There was a problem hiding this comment.
ory already has both
envsec/pkg/awsfed/awsfed.go
Outdated
| @@ -40,7 +40,7 @@ func (a *AWSFed) AWSCredsWithLocalCache( | |||
| ctx context.Context, | |||
| tok *session.Token, | |||
| ) (*types.Credentials, error) { | |||
| cache := filecache.New[*types.Credentials]("jetpack.io/envsec") | |||
| cache := filecache.New[*types.Credentials]("jetify.com/envsec") | |||
There was a problem hiding this comment.
This is cache, so no issues changing.
envsec/pkg/envsec/init.go
Outdated
| @@ -20,7 +20,7 @@ var ( | |||
| ) | |||
|
|
|||
| const ( | |||
| dirName = ".jetpack.io" | |||
| dirName = ".jetify.com" | |||
There was a problem hiding this comment.
This is gonna cause projects to be reinitialized, but that's OK.
pkg/runx/impl/httpcacher/defaults.go
Outdated
| @@ -5,7 +5,7 @@ import ( | |||
| "path/filepath" | |||
| ) | |||
|
|
|||
| const xdgSubdir = "jetpack.io/http" | |||
| const xdgSubdir = "jetify.com/http" | |||
There was a problem hiding this comment.
This is for caching so OK
There was a problem hiding this comment.
Should we do jetify/http?
pkg/runx/impl/registry/registry.go
Outdated
| @@ -12,7 +12,7 @@ import ( | |||
| "go.jetpack.io/pkg/runx/impl/types" | |||
| ) | |||
|
|
|||
| var xdgInstallationSubdir = "jetpack.io/pkgs" | |||
| var xdgInstallationSubdir = "jetify.com/pkgs" | |||
There was a problem hiding this comment.
This is for caching.
There was a problem hiding this comment.
Should we do jetify/pkgs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update jetpack.io to jetify.com. Will comment individually on backward compatibility.
How was it tested?