feat(cloud): Add custom cloud API URL configuration support #181
+201
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
adamshiervani
commented
Feb 21, 2025
•
adamshiervani
commented
- Implement RPC methods to set, get, and reset cloud URL
- Modify UI to allow configuring custom cloud API URL in developer settings
- Make a clear distinction between the different modes and their environment variables
- Dev build only needs to know the hostname of the Cloud UI
- Implement RPC methods to set, get, and reset cloud URL - Update cloud registration to remove hardcoded cloud API URL - Modify UI to allow configuring custom cloud API URL in developer settings - Remove environment-specific cloud configuration files - Simplify cloud URL configuration in UI config
|
I just tested everything and I was able to register! Once registering though I am getting a 404 on /session. For your session calls, what is the full URL for you (with host & port) I will debug some more in the morning. Thanks again! |
ym
approved these changes
Feb 21, 2025
…ear distinction between CLOUD_API and DEVICE_API.
|
@timothystewart6 Fixed! Please try again |
|
@adamshiervani Success! The entire solution can now be (easily) developed locally. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.