feat: tls #330
Merged
feat: tls #330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ym
requested review from
adamshiervani and
Copilot
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
internal/websecure/selfsign.go:183
- The use of '%w' for logging non-error values may cause formatting issues. Consider replacing '%w' with '%v' or another appropriate format specifier for error logging.
s.log.Warnf("Hostname %s is not valid: %w, from %s", hostname, err, info.Conn.RemoteAddr())
jsonrpc.go
Outdated
| } | ||
|
|
||
| //logger.Infof("Received RPC request: Method=%s, Params=%v, ID=%d", request.Method, request.Params, request.ID) | ||
| logger.Tracef("Received RPC request: Method=%s, Params=%v, ID=%w", request.Method, request.Params, request.ID) |
There was a problem hiding this comment.
The format specifier '%w' is intended for error wrapping and is not appropriate for logging non-error values such as request.ID. Consider using '%d' or '%v' based on the type of ID.
Suggested change
| logger.Tracef("Received RPC request: Method=%s, Params=%v, ID=%w", request.Method, request.Params, request.ID) | |
| logger.Tracef("Received RPC request: Method=%s, Params=%v, ID=%v", request.Method, request.Params, request.ID) |
ym
added a commit
to ym/jetkvm-kvm
that referenced
this pull request
Jun 13, 2025
ym
added a commit
to ym/jetkvm-kvm
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.