feat(usb_mass_storage): mount as disk

[ym]

No description provided.

[Copilot]

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (2)

internal/usbgadget/config.go:140

• [nitpick] Consider returning (bool, error) rather than (error, bool) to follow Go conventions and improve code readability.

func (u *UsbGadget) OverrideGadgetConfig(itemKey string, itemAttr string, value string) (error, bool) {

jsonrpc.go:488

• [nitpick] Consider specifying the allowed modes (cdrom, disk) in the error message for clearer guidance on valid input values.

return "", fmt.Errorf("invalid mode: %s", mode)

[Copilot]

The error returned by setMassStorageMode is not checked, which may lead to silent failures. Consider handling the error appropriately.

Suggested change

	setMassStorageMode(mode == CDROM)
	err := setMassStorageMode(mode == CDROM)
	if err != nil {
	virtualMediaStateMutex.Unlock()
	return fmt.Errorf("failed to set mass storage mode: %w", err)
	}

[Copilot]

The error returned by setMassStorageMode in this call is ignored. Consider checking and handling any potential error.

Suggested change

	setMassStorageMode(mode == CDROM)
	err := setMassStorageMode(mode == CDROM)
	if err != nil {
	logger.Errorf("failed to set mass storage mode: %v", err)
	return err
	}

[Copilot]

Ignoring the error from setMassStorageMode here can lead to unhandled failure scenarios. Please capture and handle the error as needed.

Suggested change

	setMassStorageMode(mode == CDROM)
	err = setMassStorageMode(mode == CDROM)
	if err != nil {
	return fmt.Errorf("failed to set mass storage mode: %w", err)
	}

[Copilot]

Pull Request Overview

This PR adds support for mounting USB mass storage as a disk rather than a CD/DVD by renaming functions and updating the UI and RPC logic accordingly.

• Rename backend function from getMassStorageMode() to getMassStorageCDROMEnabled().
• Update UI components to map .img files to "Disk" mode.
• Introduce a new gadget configuration override function in the usbgadget config.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
usb_mass_storage.go	Rename function for clarity and update mass storage mode handling
ui/src/routes/devices.$id.mount.tsx	Adjust UI logic to set USB mode to "Disk" for IMG files and update radio input properties
jsonrpc.go	Use switch-case for mode translation and update function call to reflect renaming
internal/usbgadget/config.go	Add OverrideGadgetConfig for updating gadget configurations

Comments suppressed due to low confidence (1)

usb_mass_storage.go:116

• The renaming to 'getMassStorageCDROMEnabled' improves clarity. Please ensure related documentation or comments are updated accordingly.

func getMassStorageCDROMEnabled() (bool, error) {

[Copilot]

The UI now uses 'Disk' mode for IMG files while the backend maps non-CDROM modes to 'file'. Consider aligning these terms or adding documentation to clarify this mapping for API consumers.

Suggested change

	setUsbMode("Disk");
	}
	setUsbMode("file"); // Aligning with backend terminology
	}
	// Note: The UI uses "CDROM" and "file" to match backend expectations.
	// "CDROM" is used for ISO files, and "file" is used for IMG files.