structured logging #351
Merged
structured logging #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ym
requested review from
adamshiervani,
chemhack and
Copilot
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Copilot reviewed 35 out of 37 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- go.mod: Language not supported
- internal/pion/logging/go.mod: Language not supported
Comments suppressed due to low confidence (1)
internal/usbgadget/utils.go:48
- Consider improving the log message text by explicitly including the file path (e.g. 'skipping writing to ' + filePath) for better clarity.
u.log.Trace().Str("path", filePath).Msg("skipping writing to as it already has the correct content")
5944e78 to
345c09f
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 35 out of 37 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- go.mod: Language not supported
- internal/pion/logging/go.mod: Language not supported
Comments suppressed due to low confidence (1)
internal/usbgadget/utils.go:48
- [nitpick] Consider improving the log message wording by including the file name explicitly, e.g. 'skipping writing to file as it already has the correct content'.
u.log.Trace().Str("path", filePath).Msg("skipping writing to as it already has the correct content")
c770df3 to
396a747
Compare
ym
force-pushed
the
feat/zerolog
branch
2 times, most recently
from
3feb16d to
f38ce40
Compare
Contributor
There was a problem hiding this comment.
Copilot reviewed 31 out of 32 changed files in this pull request and generated no comments.
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (2)
internal/usbgadget/utils.go:48
- [nitpick] Consider rephrasing the log message to explicitly include the file path (e.g. 'skipping writing to as it already has the correct content') so that the message remains clear even without relying solely on its structured field.
u.log.Trace().Str("path", filePath).Msg("skipping writing to as it already has the correct content")
internal/usbgadget/utils.go:55
- [nitpick] Consider rephrasing this log message similarly to include the file path directly in the message text for improved clarity.
u.log.Trace().Str("path", filePath).Msg("skipping writing to as it already has the correct content")
chemhack
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.