feat(ui): Enhance Virtual Keyboard for US #449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhere along the way, the handling of the shift-key state for letters and numbers was lost and we stopped displaying the capital/symbol for the key. Also update page up and page down to have the space in the on-screen key.
Enable insert, delete, numpad equal, print scree, scroll lock, pause, system request, break keys.
|
Ready for review @ym @adamshiervani |
This was referenced May 22, 2025
ym
pushed a commit
to ym/jetkvm-kvm
that referenced
this pull request
Sep 26, 2025
* feat(ui): Add Ctrl+Alt-Backspace combination key to Virtual Keyboard Fixes jetkvm#445 (somewhat) * fix(ui): Correct virtual keyboard display when shift key is down. Somewhere along the way, the handling of the shift-key state for letters and numbers was lost and we stopped displaying the capital/symbol for the key. Also update page up and page down to have the space in the on-screen key. * feat(ui): Add missing keys for virtual keyboard Enable insert, delete, numpad equal, print scree, scroll lock, pause, system request, break keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the display problems with shifted keys (should show capitals and symbols, but was showing (KeyX) and the state management was losing the Shift modifer.
Add the missing keys from the directional keys section, added Insert, added Print Screen/System Request, added Scroll Lock, added Pause/Break. Fixed display for the Delete key.
Added (but not exposed on normal US keyboard yet) the Numpad Equal
Builds on #447