fix(timesync): queryMultipleHttp hanging if all servers are unreachable #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where queryMultipleHttp hangs if all servers are unreachable by ensuring that each goroutine sends a result (even if nil) and the loop properly iterates over all responses until a valid result is found.
- Ensure each error case sends a nil result to the channel.
- Replace a single channel read with a for-loop that iterates over all expected responses and returns early on a non-nil result.
Comments suppressed due to low confidence (1)
internal/timesync/http.go:114
- Clarify in the function documentation whether returning on the first non-nil result is the intended behavior, to prevent any confusion on the API's usage.
now = result
|
|
||
| return <-results | ||
| for range urls { | ||
| result := <-results |
There was a problem hiding this comment.
Consider adding a comment explaining why nil results are explicitly skipped to enhance readability.
Suggested change
| result := <-results | |
| result := <-results | |
| // Skip nil results as they indicate failed or canceled HTTP queries. |
chemhack
approved these changes
Jun 12, 2025
ym
added a commit
that referenced
this pull request
Jun 12, 2025
ariedel87
pushed a commit
to ariedel87/kvm
that referenced
this pull request
Jun 13, 2025
ym
added a commit
to ym/jetkvm-kvm
that referenced
this pull request
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #576
A temporary workaround before the next release would be to disable HTTP sync.