Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy fixes #21

Merged
merged 4 commits into from
Nov 14, 2022
Merged

Clippy fixes #21

merged 4 commits into from
Nov 14, 2022

Conversation

aknarts
Copy link
Contributor

@aknarts aknarts commented Nov 13, 2022

This is mostly consideration but this passes following clippy checks

-W clippy::all -W clippy::pedantic -W clippy::nursery -W clippy::cargo -A clippy::cargo-common-metadata -A clippy::module-name-repetitions -A clippy::must-use-candidate -A clippy::let-underscore-drop -A clippy::needless-pass-by-value -A clippy::cast-sign-loss -A clippy::cast-possible-wrap -A clippy::use-self -A clippy::implicit-hasher

Notable allows:

  • cast-sign-loss/cast-possible-wrap - disabled because we are getting values from JS, and this is for sizes, I do not think that window size will overflow i32 anytime soon
  • implicit-hasher - while it would be nice to allow other hashers this overcomplicates the fixes
  • use-self - happens in web binds mostly and there is no way to fix this

This probably needs to run tests and make sure it does not break anything, i.e. feel free to reject this(plus it is big)

@jetli jetli merged commit 77aa668 into jetli:main Nov 14, 2022
@jetli
Copy link
Owner

jetli commented Nov 14, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants