Skip to content

Add a note about the billing in README #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2021
Merged

Add a note about the billing in README #46

merged 1 commit into from
Jun 4, 2021

Conversation

@maelvls
Copy link
Member

@maelvls maelvls commented Mar 31, 2021

This PR fixes one comment from @wallrj that I left over in #40:

If I was going to nitpick, I'd probably ask for even more detail on the pricing mechanism and ubbagent, but that can be in a followup.

I see there's a note about pricing in https://console.cloud.google.com/marketplace/details/jetstack-public/jetstack-secure-for-cert-manager?project=jetstack-public&authuser=0, and I wondered if that should also be added to the README file in this repo, for the benefit of users who take the CLI installation route.

/cc @wallrj

@jetstack-bot jetstack-bot requested a review from wallrj March 31, 2021 17:13
@maelvls maelvls added this to the initial-release milestone Mar 31, 2021
@maelvls maelvls modified the milestones: initial-release, next Apr 27, 2021
@maelvls @jakexks
b7d856c 
readme: add a note about the billing

Signed-off-by: Maël Valais <mael@vls.dev>
Co-authored-by: Jake Sanders <i@am.so-aweso.me>
@maelvls maelvls force-pushed the address-pr-comments-from-pr40 branch from 3191e0e to b7d856c Compare June 4, 2021 11:12
@maelvls
Copy link
Member Author

maelvls commented Jun 4, 2021 •
edited
Loading

@james-w Could you give a look at this PR

@maelvls maelvls requested review from james-w and removed request for wallrj June 4, 2021 11:14
@maelvls maelvls merged commit 2f0a110 into main Jun 4, 2021
@maelvls maelvls deleted the address-pr-comments-from-pr40 branch June 4, 2021 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@james-w james-w james-w approved these changes

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

4 participants

@maelvls @james-w @jetstack-bot