Fix group for VEI issuers #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: irbekrm <irbekrm@gmail.com>
…erequest policy CRD is not installed Signed-off-by: irbekrm <irbekrm@gmail.com>
inteon
reviewed
Jan 18, 2023
inteon
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Thank you for the fix. The policyCRDsFound change prevents an error in case IncludeCertificateRequestPolicies is true and the policy CRDs are not installed. @irbekrm can you add "writing a test to test for this error" to your backlog?
/lgtm
/approve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a typo where the wrong API group was being used in a command that lists Venafi Enhanced issuers in cluster.
Signed-off-by: irbekrm irbekrm@gmail.com