Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

Add ability to customize ingress class #101

Merged
merged 1 commit into from
Mar 13, 2017

Conversation

gianrubio
Copy link
Contributor

I'm restricting my ingresses to internal and external traffic. To do this, I'm running 2 ingress with [ingress--class] (https://github.com/kubernetes/ingress/blob/6cd21f7dea61e4df694d62857d5ea31f442962ce/core/pkg/ingress/controller/launch.go#L43) option.

When I finished the setup, I realise that kube-lego start ignoring my certificates with this message below.

time="2017-03-07T14:59:21Z" level=info msg="ignoring as unsupported ingress class 'intern'" context=ingress name=kibana namespace=log

This PR add the ability to kube-lego to work with different class (default: nginx,gce).

Ex:

LEGO_SUPPORTED_INGRESS_CLASS="intern,extern,nginx,custom"

@gianrubio gianrubio force-pushed the specify-ingress branch 3 times, most recently from b327a4b to d7f6045 Compare March 8, 2017 10:20
@simonswine simonswine self-requested a review March 13, 2017 11:47
@simonswine
Copy link
Contributor

Sorry there is a rebase needed. Otherwise looking good and mergeable

@gianrubio
Copy link
Contributor Author

@simonswine done!

@simonswine
Copy link
Contributor

@gianrubio thanks will have to fix master first, but then will merge right away

@simonswine simonswine merged commit de058f9 into jetstack:master Mar 13, 2017
@gianrubio gianrubio deleted the specify-ingress branch March 22, 2017 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants