Skip to content
This repository has been archived by the owner on Aug 26, 2021. It is now read-only.

break up infinite update loop #137 #204

Merged
merged 1 commit into from
Jun 15, 2017
Merged

Conversation

bvoss
Copy link
Contributor

@bvoss bvoss commented Jun 9, 2017

@bvoss bvoss mentioned this pull request Jun 9, 2017
@gianrubio
Copy link
Contributor

Nice job @bvoss, the nginx controller do the same treatment to compare ingress resources.

@munnerz
Copy link
Contributor

munnerz commented Jun 15, 2017

Thanks very much for this @bvoss. In future we may look at some kind of hash based check of the ingress spec to determine whether to update, but in the meantime this works perfectly.

@munnerz munnerz merged commit c6c7218 into jetstack:master Jun 15, 2017
@ahmetb
Copy link

ahmetb commented Jun 28, 2017

Is this released in a tagged version? I am using jetstack/kube-lego:0.1.4 but still seeing this behavior. Opened #216 and #198. (edit: looks like the latest release doesn't have the commit.)

@gianrubio
Copy link
Contributor

gianrubio commented Jun 28, 2017 via email

@naveensrinivasan
Copy link

@munnerz With the canary release, we are getting any acme challenge which is not getting the certs. Any clue as to what we could do?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants