-
Notifications
You must be signed in to change notification settings - Fork 93
OIDC auth request failure #186
base: master
Are you sure you want to change the base?
Conversation
@redradrat: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits. 📝 Please follow instructions in the contributing guide to update your commits with the DCO Full details of the Developer Certificate of Origin can be found at developercertificate.org. The list of commits missing DCO signoff:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @redradrat. Thanks for your PR. I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
concerns #185 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modification used and tested on debugging a misspelled option. @JoshVanL @jetack Dou you have an CI/CD that will rebuild and push the new docker image ?
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Asteb612, redradrat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'm not sure whether it's actually ok to do so from a security perspective.
Not knowing why the initial OIDC auth call failed costs a lot of time though. This should be doable debug log mode maybe?