-
Notifications
You must be signed in to change notification settings - Fork 49
Ensures results are of type *multierror.Error and call ErrorOrNil at return #391
base: master
Are you sure you want to change the base?
Conversation
/assign @simonswine |
e1b9f14
to
78a2add
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not too sure why we need that?! This is exactly as usage suggest https://github.com/hashicorp/go-multierror |
/assign @JoshVanL |
@JoshVanL: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@JoshVanL: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Due to a result being miss returned a bug was created. This PR ensures all append results are of *multierror.Error and return ErrorOrNil()