Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

WIP: Recover properly when bastion goes down #396

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dippynark
Copy link
Contributor

What this PR does / why we need it: Allows the bastion to be created by reapplying when there it goes down

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #187

Allow bastion to be recreated by reapplying

@jetstack-bot jetstack-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 1, 2018
@jetstack-bot jetstack-bot requested a review from JoshVanL August 1, 2018 13:43
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dippynark

If they are not already assigned, you can assign the PR to them by writing /assign @dippynark in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 1, 2018
@dippynark
Copy link
Contributor Author

/assign @simonswine

@dippynark
Copy link
Contributor Author

/test verify quick

@dippynark
Copy link
Contributor Author

/assign
/unassign @simonswine

@jetstack-bot jetstack-bot assigned dippynark and unassigned simonswine Aug 2, 2018
@simonswine
Copy link
Contributor

I need a bit more context what this is trying to achieve

@dippynark
Copy link
Contributor Author

@simonswine at the time this was written, the bastion would not be recreated from a reapply if it was deleted or was down for whatever reason - it also tries to speed up plan time when the bastion is down (so that the tarmak vault cluster resource and vault token resources don't hang for ages) but due to issues with terraform not rereading data resources at refresh time (hashicorp/terraform#17034) this was not perfect

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2018
@jetstack-bot
Copy link
Collaborator

@dippynark: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dippynark dippynark changed the title Recover properly when bastion goes down WIP: Recover properly when bastion goes down Sep 11, 2018
@jetstack-bot jetstack-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Sep 11, 2018
@jetstack-bot
Copy link
Collaborator

@dippynark: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
tarmak-quick-verify 7306c38 link /test verify quick
tarmak-puppet-module-tarmak-acceptance-1-14-centos 7306c38 link /test puppet-tarmak-acceptance-centos v1.14

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot recover from failed bastion instance
3 participants