Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Adds documentation for custom binary URLs #420

Closed

Conversation

JoshVanL
Copy link
Contributor

@JoshVanL JoshVanL commented Aug 8, 2018

What this PR does / why we need it:
Adds some documentation on how to use custom URLs for various tools and binaries in tarmak.

fixes #393

NONE

/assign @simonswine

@jetstack-bot jetstack-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 8, 2018
@jetstack-bot jetstack-bot requested a review from kragniz August 8, 2018 10:15
@jetstack-bot jetstack-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 8, 2018
@jetstack-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: simonswine

If they are not already assigned, you can assign the PR to them by writing /assign @simonswine in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 24, 2018
@jetstack-bot
Copy link
Collaborator

@JoshVanL: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoshVanL
Copy link
Contributor Author

/close

@jetstack-bot
Copy link
Collaborator

@JoshVanL: Closing this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize vault-helper download URL
3 participants