Merge pull request #235 from jetstreamapp/bug/getFlattenedField

Fix getFlattenedFields with invalid data
jetstreamapp · Jul 25, 2023 · f3f0a57 · f3f0a57
2 parents 15475d1 + 64bfdfe
commit f3f0a57
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## 4.9.2
+
+July 24, 2023
+
+Ensure `getFlattenedFields` does not throw exception if query does not have `fields` property.
+
 ## 4.9.1
 
 May 29, 2023

diff --git a/src/api/public-utils.ts b/src/api/public-utils.ts
@@ -157,6 +157,9 @@ export function getFlattenedFields(
   }
   query = isFieldSubquery(query) ? query.subquery : query;
   const fields = query.fields;
+  if (!fields) {
+    return [];
+  }
   // if a relationship field is used in a group by, then Salesforce removes the relationship portion of the field in the returned records
   let groupByFields: { [field: string]: string } = {};
   if (!!query.groupBy) {

diff --git a/test/public-utils.spec.ts b/test/public-utils.spec.ts
@@ -227,4 +227,10 @@ describe('getFlattenedFields', () => {
     const fields = utils.getFlattenedFields(fieldSubquery.subquery);
     expect(fields).toEqual(['LastName']);
   });
+
+  it(`Should not blow up with invalid input`, () => {
+    expect(utils.getFlattenedFields({})).toEqual([]);
+    expect(utils.getFlattenedFields(null as any)).toEqual([]);
+    expect(utils.getFlattenedFields({ fields: [] })).toEqual([]);
+  });
 });