Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate query logs syntax errors to the console #56

Closed
1 of 2 tasks
paustint opened this issue Feb 8, 2019 · 0 comments · Fixed by #57
Closed
1 of 2 tasks

Validate query logs syntax errors to the console #56

paustint opened this issue Feb 8, 2019 · 0 comments · Fixed by #57
Assignees
@paustint
Labels
bug Something isn't working
Milestone
Release-1

Comments

@paustint
Copy link
Collaborator

paustint commented Feb 8, 2019

  • Feature
  • Bug Request

Description

This library should never log anything to the console unless the user explicitly turns on debug logging.

image
@paustint paustint added the bug Something isn't working label Feb 8, 2019
@paustint paustint added this to the Release-1 milestone Feb 8, 2019
@paustint paustint self-assigned this Feb 8, 2019
paustint added a commit that referenced this issue Feb 8, 2019
@paustint
Validate query logs syntax errors to the console #56
d603821 
Added an error listener to the lexer to ensure that all error message are handled through the same error handler
and do not print out to the console

resolves #56
@paustint paustint mentioned this issue Feb 8, 2019
Merged
paustint added a commit that referenced this issue Feb 8, 2019
@paustint
Merge pull request #57 from paustint/bug-56
0909f18 
Validate query logs syntax errors to the console #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paustint paustint

Labels
bug Something isn't working
Projects
None yet
Milestone
Release-1
Development

Successfully merging a pull request may close this issue.

Validate query logs syntax errors to the console #56 jetstreamapp/soql-parser-js
1 participant
@paustint