Issue #4581 - remove unnecessary javadoc on Override methods

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
jetty · Feb 18, 2020 · 55748f1 · 55748f1
1 parent 3129202
commit 55748f1
Show file tree

Hide file tree

Showing 143 changed files with 1 addition and 1,398 deletions.
diff --git a/apache-jsp/src/main/java/org/eclipse/jetty/apache/jsp/JettyJasperInitializer.java b/apache-jsp/src/main/java/org/eclipse/jetty/apache/jsp/JettyJasperInitializer.java
@@ -54,27 +54,18 @@ private NullTldScanner(ServletContext context, boolean namespaceAware, boolean v
             super(context, namespaceAware, validation, blockExternal);
         }
 
-        /**
-         * @see org.apache.jasper.servlet.TldScanner#scan()
-         */
         @Override
         public void scan() throws IOException, SAXException
         {
             return; //do nothing
         }
 
-        /**
-         * @see org.apache.jasper.servlet.TldScanner#getListeners()
-         */
         @Override
         public List<String> getListeners()
         {
             return Collections.emptyList();
         }
 
-        /**
-         * @see org.apache.jasper.servlet.TldScanner#scanJars()
-         */
         @Override
         public void scanJars()
         {

diff --git a/apache-jsp/src/main/java/org/eclipse/jetty/apache/jsp/JettyTldPreScanned.java b/apache-jsp/src/main/java/org/eclipse/jetty/apache/jsp/JettyTldPreScanned.java
@@ -48,9 +48,6 @@ public JettyTldPreScanned(ServletContext context, boolean namespaceAware, boolea
         _jettyPreScannedURLs = preScannedTlds;
     }
 
-    /**
-     * @see org.apache.jasper.servlet.TldPreScanned#scanJars()
-     */
     @Override
     public void scanJars()
     {

diff --git a/apache-jsp/src/test/java/org/eclipse/jetty/jsp/TestJettyJspServlet.java b/apache-jsp/src/test/java/org/eclipse/jetty/jsp/TestJettyJspServlet.java
@@ -62,9 +62,6 @@ public DfltServlet()
             super();
         }
 
-        /**
-         * @see javax.servlet.http.HttpServlet#doGet(javax.servlet.http.HttpServletRequest, javax.servlet.http.HttpServletResponse)
-         */
         @Override
         protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException
         {

diff --git a/...t/async-rest-jar/src/main/java/org/eclipse/jetty/example/asyncrest/SerialRestServlet.java b/...t/async-rest-jar/src/main/java/org/eclipse/jetty/example/asyncrest/SerialRestServlet.java
@@ -28,7 +28,6 @@
 import java.util.Map;
 import java.util.Queue;
 import javax.servlet.ServletException;
-import javax.servlet.http.HttpServlet;
 import javax.servlet.http.HttpServletRequest;
 import javax.servlet.http.HttpServletResponse;
 
@@ -94,10 +93,6 @@ protected void doGet(HttpServletRequest request, HttpServletResponse response) t
         out.close();
     }
 
-    /**
-     * @see HttpServlet#doPost(HttpServletRequest request, HttpServletResponse
-     * response)
-     */
     @Override
     protected void doPost(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException
     {

diff --git a/jetty-annotations/src/main/java/org/eclipse/jetty/annotations/AnnotationConfiguration.java b/jetty-annotations/src/main/java/org/eclipse/jetty/annotations/AnnotationConfiguration.java
@@ -332,9 +332,6 @@ public void addDiscoverableAnnotationHandler(AbstractDiscoverableAnnotationHandl
         _discoverableAnnotationHandlers.add(handler);
     }
 
-    /**
-     * @see org.eclipse.jetty.webapp.AbstractConfiguration#configure(org.eclipse.jetty.webapp.WebAppContext)
-     */
     @Override
     public void configure(WebAppContext context) throws Exception
     {
@@ -371,9 +368,6 @@ public void configure(WebAppContext context) throws Exception
         }
     }
 
-    /**
-     * @see org.eclipse.jetty.webapp.AbstractConfiguration#postConfigure(org.eclipse.jetty.webapp.WebAppContext)
-     */
     @Override
     public void postConfigure(WebAppContext context) throws Exception
     {
@@ -563,9 +557,6 @@ protected int getMaxScanWait(WebAppContext context)
         return Integer.getInteger(MAX_SCAN_WAIT, DEFAULT_MAX_SCAN_WAIT).intValue();
     }
 
-    /**
-     * @see org.eclipse.jetty.webapp.AbstractConfiguration#cloneConfigure(org.eclipse.jetty.webapp.WebAppContext, org.eclipse.jetty.webapp.WebAppContext)
-     */
     @Override
     public void cloneConfigure(WebAppContext template, WebAppContext context) throws Exception
     {

diff --git a/...nnotations/src/main/java/org/eclipse/jetty/annotations/DeclareRolesAnnotationHandler.java b/...nnotations/src/main/java/org/eclipse/jetty/annotations/DeclareRolesAnnotationHandler.java
@@ -43,9 +43,6 @@ public DeclareRolesAnnotationHandler(WebAppContext context)
         _context = context;
     }
 
-    /**
-     * @see org.eclipse.jetty.annotations.AnnotationIntrospector.AbstractIntrospectableAnnotationHandler#doHandle(java.lang.Class)
-     */
     @Override
     public void doHandle(Class clazz)
     {

diff --git a/...tations/src/main/java/org/eclipse/jetty/annotations/MultiPartConfigAnnotationHandler.java b/...tations/src/main/java/org/eclipse/jetty/annotations/MultiPartConfigAnnotationHandler.java
@@ -42,9 +42,6 @@ public MultiPartConfigAnnotationHandler(WebAppContext context)
         _context = context;
     }
 
-    /**
-     * @see org.eclipse.jetty.annotations.AnnotationIntrospector.AbstractIntrospectableAnnotationHandler#doHandle(java.lang.Class)
-     */
     @Override
     public void doHandle(Class clazz)
     {

diff --git a/...ions/src/main/java/org/eclipse/jetty/annotations/ServletContainerInitializersStarter.java b/...ions/src/main/java/org/eclipse/jetty/annotations/ServletContainerInitializersStarter.java
@@ -43,11 +43,6 @@ public ServletContainerInitializersStarter(WebAppContext context)
         _context = context;
     }
 
-    /**
-     * Call the doStart method of the ServletContainerInitializers
-     *
-     * @see org.eclipse.jetty.util.component.AbstractLifeCycle#doStart()
-     */
     @Override
     public void doStart()
     {

diff --git a/...tations/src/main/java/org/eclipse/jetty/annotations/ServletSecurityAnnotationHandler.java b/...tations/src/main/java/org/eclipse/jetty/annotations/ServletSecurityAnnotationHandler.java
@@ -65,9 +65,6 @@ public ServletSecurityAnnotationHandler(WebAppContext wac)
         _context = wac;
     }
 
-    /**
-     * @see org.eclipse.jetty.annotations.AnnotationIntrospector.IntrospectableAnnotationHandler#handle(java.lang.Class)
-     */
     @Override
     public void doHandle(Class clazz)
     {

diff --git a/jetty-annotations/src/main/java/org/eclipse/jetty/annotations/WebFilterAnnotation.java b/jetty-annotations/src/main/java/org/eclipse/jetty/annotations/WebFilterAnnotation.java
@@ -54,9 +54,6 @@ public WebFilterAnnotation(WebAppContext context, String className, Resource res
         super(context, className, resource);
     }
 
-    /**
-     * @see DiscoveredAnnotation#apply()
-     */
     @Override
     public void apply()
     {

diff --git a/jetty-annotations/src/main/java/org/eclipse/jetty/annotations/WebListenerAnnotation.java b/jetty-annotations/src/main/java/org/eclipse/jetty/annotations/WebListenerAnnotation.java
@@ -54,9 +54,6 @@ public WebListenerAnnotation(WebAppContext context, String className, Resource r
         super(context, className, resource);
     }
 
-    /**
-     * @see DiscoveredAnnotation#apply()
-     */
     @Override
     public void apply()
     {

diff --git a/jetty-annotations/src/main/java/org/eclipse/jetty/annotations/WebServletAnnotation.java b/jetty-annotations/src/main/java/org/eclipse/jetty/annotations/WebServletAnnotation.java
@@ -57,9 +57,6 @@ public WebServletAnnotation(WebAppContext context, String className, Resource re
         super(context, className, resource);
     }
 
-    /**
-     * @see DiscoveredAnnotation#apply()
-     */
     @Override
     public void apply()
     {

diff --git a/jetty-ant/src/main/java/org/eclipse/jetty/ant/AntWebAppContext.java b/jetty-ant/src/main/java/org/eclipse/jetty/ant/AntWebAppContext.java
@@ -563,9 +563,6 @@ public void setWar(String path)
         }
     }
 
-    /**
-     *
-     */
     @Override
     public void doStart()
     {

diff --git a/jetty-ant/src/main/java/org/eclipse/jetty/ant/JettyStopTask.java b/jetty-ant/src/main/java/org/eclipse/jetty/ant/JettyStopTask.java
@@ -49,9 +49,6 @@ public JettyStopTask()
         TaskLog.setTask(this);
     }
 
-    /**
-     * @see org.apache.tools.ant.Task#execute()
-     */
     @Override
     public void execute() throws BuildException
     {

diff --git a/jetty-ant/src/main/java/org/eclipse/jetty/ant/ServerProxyImpl.java b/jetty-ant/src/main/java/org/eclipse/jetty/ant/ServerProxyImpl.java
@@ -254,9 +254,6 @@ public void setTempDirectory(File tempDirectory)
         this.tempDirectory = tempDirectory;
     }
 
-    /**
-     * @see org.eclipse.jetty.ant.utils.ServerProxy#start()
-     */
     @Override
     public void start()
     {
@@ -299,9 +296,6 @@ public void start()
         }
     }
 
-    /**
-     * @see org.eclipse.jetty.ant.utils.ServerProxy#getProxiedObject()
-     */
     @Override
     public Object getProxiedObject()
     {

diff --git a/jetty-client/src/main/java/org/eclipse/jetty/client/ConnectionPool.java b/jetty-client/src/main/java/org/eclipse/jetty/client/ConnectionPool.java
@@ -70,11 +70,6 @@ public interface ConnectionPool extends Closeable
      */
     boolean remove(Connection connection);
 
-    /**
-     * Closes this ConnectionPool.
-     *
-     * @see #isClosed()
-     */
     @Override
     void close();
 

diff --git a/jetty-deploy/src/main/java/org/eclipse/jetty/deploy/PropertiesConfigurationManager.java b/jetty-deploy/src/main/java/org/eclipse/jetty/deploy/PropertiesConfigurationManager.java
@@ -81,9 +81,6 @@ public void put(@Name("name") String name, @Name("value") String value)
         _map.put(name, value);
     }
 
-    /**
-     * @see org.eclipse.jetty.deploy.ConfigurationManager#getProperties()
-     */
     @Override
     public Map<String, String> getProperties()
     {

diff --git a/...manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStoreFactory.java b/...manager/src/main/java/org/eclipse/jetty/gcloud/session/GCloudSessionDataStoreFactory.java
@@ -78,9 +78,6 @@ public void setNamespace(String namespace)
         _namespace = namespace;
     }
 
-    /**
-     * @see org.eclipse.jetty.server.session.SessionDataStoreFactory#getSessionDataStore(org.eclipse.jetty.server.session.SessionHandler)
-     */
     @Override
     public SessionDataStore getSessionDataStore(SessionHandler handler) throws Exception
     {

diff --git a/jetty-http-spi/src/main/java/org/eclipse/jetty/http/spi/JettyHttpsExchange.java b/jetty-http-spi/src/main/java/org/eclipse/jetty/http/spi/JettyHttpsExchange.java
@@ -171,9 +171,6 @@ public String toString()
         return _delegate.toString();
     }
 
-    /**
-     * @see com.sun.net.httpserver.HttpsExchange#getSSLSession()
-     */
     @Override
     public SSLSession getSSLSession()
     {

diff --git a/jetty-http/src/main/java/org/eclipse/jetty/http/Http1FieldPreEncoder.java b/jetty-http/src/main/java/org/eclipse/jetty/http/Http1FieldPreEncoder.java
@@ -28,18 +28,12 @@
 public class Http1FieldPreEncoder implements HttpFieldPreEncoder
 {
 
-    /**
-     * @see org.eclipse.jetty.http.HttpFieldPreEncoder#getHttpVersion()
-     */
     @Override
     public HttpVersion getHttpVersion()
     {
         return HttpVersion.HTTP_1_0;
     }
 
-    /**
-     * @see org.eclipse.jetty.http.HttpFieldPreEncoder#getEncodedField(org.eclipse.jetty.http.HttpHeader, java.lang.String, java.lang.String)
-     */
     @Override
     public byte[] getEncodedField(HttpHeader header, String headerString, String value)
     {

diff --git a/jetty-http/src/main/java/org/eclipse/jetty/http/MetaData.java b/jetty-http/src/main/java/org/eclipse/jetty/http/MetaData.java
@@ -109,10 +109,6 @@ public long getContentLength()
         return _contentLength;
     }
 
-    /**
-     * @return an iterator over the HTTP fields
-     * @see #getFields()
-     */
     @Override
     public Iterator<HttpField> iterator()
     {

diff --git a/...y-http2/http2-hpack/src/main/java/org/eclipse/jetty/http2/hpack/HpackFieldPreEncoder.java b/...y-http2/http2-hpack/src/main/java/org/eclipse/jetty/http2/hpack/HpackFieldPreEncoder.java
@@ -31,18 +31,12 @@
 public class HpackFieldPreEncoder implements HttpFieldPreEncoder
 {
 
-    /**
-     * @see org.eclipse.jetty.http.HttpFieldPreEncoder#getHttpVersion()
-     */
     @Override
     public HttpVersion getHttpVersion()
     {
         return HttpVersion.HTTP_2;
     }
 
-    /**
-     * @see org.eclipse.jetty.http.HttpFieldPreEncoder#getEncodedField(org.eclipse.jetty.http.HttpHeader, java.lang.String, java.lang.String)
-     */
     @Override
     public byte[] getEncodedField(HttpHeader header, String name, String value)
     {

diff --git a/...common/src/main/java/org/eclipse/jetty/session/infinispan/InfinispanSessionDataStore.java b/...common/src/main/java/org/eclipse/jetty/session/infinispan/InfinispanSessionDataStore.java
@@ -82,9 +82,6 @@ public void setQueryManager(QueryManager queryManager)
         _queryManager = queryManager;
     }
 
-    /**
-     * @see org.eclipse.jetty.server.session.SessionDataStore#load(String)
-     */
     @Override
     protected void doStart() throws Exception
     {

diff --git a/...src/main/java/org/eclipse/jetty/session/infinispan/InfinispanSessionDataStoreFactory.java b/...src/main/java/org/eclipse/jetty/session/infinispan/InfinispanSessionDataStoreFactory.java
@@ -49,9 +49,6 @@ public void setInfinispanIdleTimeoutSec(int infinispanIdleTimeoutSec)
         _infinispanIdleTimeoutSec = infinispanIdleTimeoutSec;
     }
 
-    /**
-     * @see org.eclipse.jetty.server.session.SessionDataStoreFactory#getSessionDataStore(org.eclipse.jetty.server.session.SessionHandler)
-     */
     @Override
     public SessionDataStore getSessionDataStore(SessionHandler handler) throws Exception
     {

diff --git a/jetty-io/src/main/java/org/eclipse/jetty/io/ByteArrayEndPoint.java b/jetty-io/src/main/java/org/eclipse/jetty/io/ByteArrayEndPoint.java
@@ -355,9 +355,6 @@ public boolean hasMore()
         return getOutput().position() > 0;
     }
 
-    /*
-     * @see org.eclipse.io.EndPoint#fill(org.eclipse.io.Buffer)
-     */
     @Override
     public int fill(ByteBuffer buffer) throws IOException
     {
@@ -400,9 +397,6 @@ else if (filled < 0)
         return filled;
     }
 
-    /*
-     * @see org.eclipse.io.EndPoint#flush(org.eclipse.io.Buffer, org.eclipse.io.Buffer, org.eclipse.io.Buffer)
-     */
     @Override
     public boolean flush(ByteBuffer... buffers) throws IOException
     {
@@ -450,9 +444,6 @@ public boolean flush(ByteBuffer... buffers) throws IOException
         return flushed;
     }
 
-    /**
-     *
-     */
     @Override
     public void reset()
     {
@@ -465,9 +456,6 @@ public void reset()
         super.reset();
     }
 
-    /*
-     * @see org.eclipse.io.EndPoint#getConnection()
-     */
     @Override
     public Object getTransport()
     {

diff --git a/jetty-jaas/src/main/java/org/eclipse/jetty/jaas/spi/AbstractLoginModule.java b/jetty-jaas/src/main/java/org/eclipse/jetty/jaas/spi/AbstractLoginModule.java
@@ -179,10 +179,6 @@ public void setCommitted(boolean commitState)
         this.commitState = commitState;
     }
 
-    /**
-     * @throws LoginException if unable to abort
-     * @see javax.security.auth.spi.LoginModule#abort()
-     */
     @Override
     public boolean abort() throws LoginException
     {

diff --git a/jetty-jaspi/src/main/java/org/eclipse/jetty/security/jaspi/JaspiAuthenticator.java b/jetty-jaspi/src/main/java/org/eclipse/jetty/security/jaspi/JaspiAuthenticator.java
@@ -94,9 +94,6 @@ public String getAuthMethod()
         return "JASPI";
     }
 
-    /**
-     * @see org.eclipse.jetty.security.authentication.LoginAuthenticator#login(java.lang.String, java.lang.Object, javax.servlet.ServletRequest)
-     */
     @Override
     public UserIdentity login(String username, Object password, ServletRequest request)
     {

diff --git a/jetty-jaspi/src/test/java/org/eclipse/jetty/security/jaspi/JaspiTest.java b/jetty-jaspi/src/test/java/org/eclipse/jetty/security/jaspi/JaspiTest.java
@@ -69,18 +69,12 @@ public void putUser(String username, Credential credential, String[] roles)
             _roles.put(username, roles);
         }
 
-        /**
-         * @see org.eclipse.jetty.security.AbstractLoginService#loadRoleInfo(org.eclipse.jetty.security.AbstractLoginService.UserPrincipal)
-         */
         @Override
         protected String[] loadRoleInfo(UserPrincipal user)
         {
             return _roles.get(user.getName());
         }
 
-        /**
-         * @see org.eclipse.jetty.security.AbstractLoginService#loadUserInfo(java.lang.String)
-         */
         @Override
         protected UserPrincipal loadUserInfo(String username)
         {
-Original file line number
+Diff line change
@@ Expand Up / @@ -563,9 +563,6 @@ public void setWar(String path) @@
             }
         }
-        /**
-         *
-         */
         @Override
         public void doStart()
         {
@@ Expand Down @@