Move h2spec exec to a profile (#12209)

* move h2spec plugin exec to a profile --------- Signed-off-by: Olivier Lamy <olamy@apache.org>
jetty · Aug 30, 2024 · e1cd1f5 · e1cd1f5
1 parent 4755fa3
commit e1cd1f5
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 29 deletions.
diff --git a/jetty-core/jetty-http2/jetty-http2-tests/pom.xml b/jetty-core/jetty-http2/jetty-http2-tests/pom.xml
@@ -72,33 +72,40 @@
             --add-reads org.eclipse.jetty.http2.server=org.eclipse.jetty.logging</argLine>
         </configuration>
       </plugin>
-      <plugin>
-        <groupId>org.mortbay.jetty</groupId>
-        <artifactId>h2spec-maven-plugin</artifactId>
-        <version>1.0.12</version>
-        <configuration>
-          <mainClass>org.eclipse.jetty.http2.tests.H2SpecServer</mainClass>
-          <skip>${h2spec.skip}</skip>
-          <junitPackage>org.eclipse.jetty.h2spec</junitPackage>
-          <skipNoDockerAvailable>true</skipNoDockerAvailable>
-          <excludeSpecs>
-            <excludeSpec>3.5 - Sends invalid connection preface</excludeSpec>
-          </excludeSpecs>
-        </configuration>
-        <executions>
-          <execution>
-            <id>h2spec</id>
-            <goals>
-              <goal>h2spec</goal>
-            </goals>
-            <phase>test</phase>
-          </execution>
-        </executions>
-      </plugin>
     </plugins>
   </build>
 
   <profiles>
+    <profile>
+      <id>h2spec</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.mortbay.jetty</groupId>
+            <artifactId>h2spec-maven-plugin</artifactId>
+            <version>1.0.13</version>
+            <configuration>
+              <mainClass>org.eclipse.jetty.http2.tests.H2SpecServer</mainClass>
+              <skip>${h2spec.skip}</skip>
+              <junitPackage>org.eclipse.jetty.h2spec</junitPackage>
+              <skipNoDockerAvailable>true</skipNoDockerAvailable>
+              <excludeSpecs>
+                <excludeSpec>3.5 - Sends invalid connection preface</excludeSpec>
+              </excludeSpecs>
+            </configuration>
+            <executions>
+              <execution>
+                <id>h2spec</id>
+                <goals>
+                  <goal>h2spec</goal>
+                </goals>
+                <phase>test</phase>
+              </execution>
+            </executions>
+          </plugin>
+        </plugins>
+      </build>
+    </profile>
     <profile>
       <id>run-spec-server</id>
       <build>

diff --git a/pom.xml b/pom.xml
@@ -192,7 +192,6 @@
     <gson.version>2.11.0</gson.version>
     <guava.version>33.2.1-jre</guava.version>
     <guice.version>7.0.0</guice.version>
-    <h2spec.maven.plugin.version>1.0.13</h2spec.maven.plugin.version>
     <hamcrest.version>2.2</hamcrest.version>
     <hazelcast.version>5.4.0</hazelcast.version>
     <hibernate.search.version>7.1.1.Final</hibernate.search.version>
@@ -1670,11 +1669,6 @@
           <artifactId>jacoco-maven-plugin</artifactId>
           <version>${jacoco.maven.plugin.version}</version>
         </plugin>
-        <plugin>
-          <groupId>org.mortbay.jetty</groupId>
-          <artifactId>h2spec-maven-plugin</artifactId>
-          <version>${h2spec.maven.plugin.version}</version>
-        </plugin>
       </plugins>
     </pluginManagement>
     <plugins>