Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow easy configuration of Scheduler-Threads and name them more appropriate #1036

Closed
laeubi opened this issue Oct 26, 2016 · 0 comments
Closed

Comments

@laeubi
Copy link
Contributor

laeubi commented Oct 26, 2016

This is related to a new-post https://dev.eclipse.org/mhonarc/lists/jetty-users/msg07333.html

Jetty seem to execute AsyncListener.onTimeout() in a special Scheduler-Thread (one per connector and one for detecting LowResource-Conditions?). The Problem is, if any work in AsyncListener.onTimeout() takes longer (e.g. cancel a background task) then the timout-processing of the container is stopping completely. If you have an application that relies on timeout (e.g. long polling) this can slow down the whole processing.

Regardless of if this is considered "bad" it would be usefull to make it

  1. possible to easy configure the number of Scheduler-Threads, currently this is hardcoded to 1 and you have to implement your own Scheduler and call the full blown ServerConnector cunstructor to change this
  2. Make the naming of the threads more appropriate, currently they are named Scheduler-12345678, I would suggest something like Scheduler-http-8080, Scheduler-https-8433, Scheduler-lowresource or such, maybe appended with a number
gregw added a commit that referenced this issue Sep 12, 2019
Allows scheduler configuration

Signed-off-by: Greg Wilkins <gregw@webtide.com>
sbordet added a commit that referenced this issue Sep 17, 2019
@sbordet sbordet closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants