Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify documentation about how to make a non-blocking handler tree #10484

Closed
lorban opened this issue Sep 6, 2023 · 1 comment · Fixed by #10934
Closed

Clarify documentation about how to make a non-blocking handler tree #10484

lorban opened this issue Sep 6, 2023 · 1 comment · Fixed by #10934
Labels
Documentation Enhancement Performance
Milestone
12.0.x

Comments

@lorban
Copy link
Contributor

lorban commented Sep 6, 2023

Jetty version(s)
12.0.x

Enhancement Description
Since 12, the Core API allows writing entirely non-blocking handlers by extending Handler.Abstract.NonBlocking that are executed by the AdaptiveExecutionStrategy's ProduceConsume sub-strategy.

Currently, the documentation mentions this fact but the information is scattered across many chapters. It also doesn't mention the fact that the entire handler tree has to be non-blocking, nor common pitfalls like the fact that ContextHandlerCollection is dynamic by default, which prevents it from being non-blocking.

This should be clarified.
@lorban lorban added this to the 12.0.x milestone Sep 6, 2023
@sbordet sbordet moved this to 🏗 In progress in Jetty 12.0.4 - FROZEN Nov 28, 2023
sbordet added a commit that referenced this issue Nov 28, 2023
@sbordet
Fixes #10484 - Clarify documentation about how to make a non-blocking…
0f4a9d0 
… handler tree.

Added documentation about non-blocking Handlers.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request Nov 28, 2023 that will close this issue
Fixes #10484 - Clarify documentation about how to make a non-blocking… #10934
Merged
sbordet added a commit that referenced this issue Nov 30, 2023
@sbordet
Fixes #10484 - Clarify documentation about how to make a non-blocking… (
0ca80b9 
#10934)

Added documentation about non-blocking Handlers.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet
Copy link
Contributor

sbordet commented Nov 30, 2023

Fixed by #10934.

@sbordet sbordet closed this as completed Nov 30, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.4 - FROZEN Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Enhancement Performance
Projects
No open projects
Jetty 12.0.4 - FROZEN
Status: ✅ Done
Milestone
12.0.x
Development

Successfully merging a pull request may close this issue.

Fixes #10484 - Clarify documentation about how to make a non-blocking… jetty/jetty.project
3 participants
@joakime @sbordet @lorban