Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate leak-resistant ConcurrentPool #10569

Closed
lorban opened this issue Sep 22, 2023 · 2 comments
Closed

Investigate leak-resistant ConcurrentPool #10569

lorban opened this issue Sep 22, 2023 · 2 comments
Labels
Enhancement Stale For auto-closed stale issues and pull requests

Comments

@lorban
Copy link
Contributor

lorban commented Sep 22, 2023

Jetty version(s)
12.0.x

Enhancement Description
ConcurrentPool uses hard references to the pooled objects, so if those are leaked (i.e.: dereferenced instead of re-pooled) this lowers the pool's performance and usefulness.

We should investigate if it would be possible to find a way to make the pooled object garbage-collectible when it is out of the pool and detect which pooled objects got garbage collected to re-pool them or at least remove the related entry from the pool.
@lorban lorban mentioned this issue Sep 22, 2023
Merged
lorban added a commit that referenced this issue Sep 27, 2023
@lorban
#10569 prototype leak-resistant concurrent pool
28a670e 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban mentioned this issue Sep 27, 2023
Closed
lorban added a commit that referenced this issue Sep 27, 2023
@lorban
#10569 prototype leak-resistant concurrent pool
94d95fa 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Sep 27, 2023
@lorban
#10569 prototype leak-resistant concurrent pool
79cdf36 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Sep 27, 2023
@lorban
#10569 prototype leak-resistant concurrent pool
5e5a5c5 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Sep 27, 2023
@lorban
#10569 prototype leak-resistant concurrent pool
feb8af9 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Sep 27, 2023
@lorban
#10569 prototype leak-resistant concurrent pool
2749b3b 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Oct 17, 2023
@lorban
#10569 handle review comments
0c3c9af 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Oct 18, 2023
@lorban
#10569 improve warning on detected leaks and make weakly-references e…
df6ff99 
…ntries configurable

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban added a commit that referenced this issue Oct 19, 2023
@lorban
#10569 improve test and javadoc
9d8cebc 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Sep 22, 2024
@lorban
Copy link
Contributor Author

lorban commented Sep 23, 2024

Done in #10787

@lorban lorban closed this as completed Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Stale For auto-closed stale issues and pull requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lorban