Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect setting of content type with charset encoding before and after PrintWriter obtained #10716

Closed
janbartel opened this issue Oct 12, 2023 · 1 comment · Fixed by #10737
Closed

Incorrect setting of content type with charset encoding before and after PrintWriter obtained #10716

janbartel opened this issue Oct 12, 2023 · 1 comment · Fixed by #10737
Assignees
@janbartel
Labels
Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)

Comments

@janbartel
Copy link
Contributor

Related to tck omnibus issue #10712.

Tests:

com/sun/ts/tests/servlet/api/jakarta_servlet/servletresponse/URLClient.java.getContentTypeNull2Test
com/sun/ts/tests/servlet/api/jakarta_servlet/servletresponse/URLClient.java.getWriterAfterTest
com/sun/ts/tests/servlet/pluggability/api/jakarta_servlet/servletresponse/URLClient.java.getContentTypeNull2Test
com/sun/ts/tests/servlet/pluggability/api/jakarta_servlet/servletresponse/URLClient.java.getWriterAfterTest

These tests play around with calling response.setContentType() before and after the PrintWriter is obtained, and also setting the content type with and without a character encoding.
@janbartel janbartel added Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc) labels Oct 12, 2023
@janbartel janbartel mentioned this issue Oct 12, 2023
Closed
@janbartel janbartel self-assigned this Oct 12, 2023
janbartel added a commit that referenced this issue Oct 16, 2023
@janbartel
Issue #10716 Prevent charset change after PrintWriter obtained.
a7952cd
janbartel added a commit that referenced this issue Oct 16, 2023
@janbartel
Issue #10716 tck compliance for setting response charset
d8b9e1e
@gregw gregw mentioned this issue Oct 16, 2023
Merged
@gregw gregw linked a pull request Oct 16, 2023 that will close this issue
Jetty 12.0.x 10716 charset printwriter #10737
Merged
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.3 - FROZEN Oct 16, 2023
janbartel added a commit that referenced this issue Oct 19, 2023
@janbartel @gregw
Jetty 12.0.x 10716 charset printwriter (#10737)
467f026 
* Issue #10716 tck compliance for setting response charset

---------

Co-authored-by: gregw <gregw@webtide.com>
@janbartel
Copy link
Contributor Author

Fixed via #10737

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.3 - FROZEN Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
Bug For general bugs on Jetty side TCK For various Specification Test Compatibility Kits (eg: Servlet, WebSocket, HTTP/2, etc)
Projects
No open projects
Jetty 12.0.3 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Jetty 12.0.x 10716 charset printwriter jetty/jetty.project
1 participant
@janbartel