Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate if the secondary_super_cache is stable #10781

Closed
lorban opened this issue Oct 25, 2023 · 5 comments
Closed

Investigate if the secondary_super_cache is stable #10781

lorban opened this issue Oct 25, 2023 · 5 comments
Labels
Performance Stale For auto-closed stale issues and pull requests

Comments

@lorban
Copy link
Contributor

lorban commented Oct 25, 2023

Jetty version(s)
12.0.x

Enhancement Description
JDK-8180450 was filed because under certain conditions, the JVM's handling of casts to interfaces can cause a noticeable slowdown. RedHat has written an agent to help diagnose if a java piece of code is impacted by this problem or not.

We should investigate if Jetty is impacted by this perf issue with the help of RH's type pollution agent.
@lorban
Copy link
Contributor Author

lorban commented Oct 25, 2023 •
edited
Loading

Here are two reports generated by the type pollution agent: this one from a JVM running the jetty load generator, and that one from a JVM running the jetty server.

They were generated on a locally-run benchmark running for 15s with two loaders generating 60k RPS on a single server. Only one of the two loaders' report is included as the two loader reports are nearly identical.

@sbordet
Copy link
Contributor

sbordet commented Oct 25, 2023

cc @franz1981

@franz1981
Copy link

FYI just fixed the stack trace level RedHatPerf/type-pollution-agent#18

lorban added a commit that referenced this issue Oct 27, 2023
@lorban
#10781 try to stabilize secondary_super_cache
c22166f 
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@lorban lorban mentioned this issue Oct 27, 2023
Merged
lorban added a commit that referenced this issue Nov 1, 2023
@lorban
Stabilize secondary_super_cache in server code (#10802)
5e747ac 
#10781 Stabilize secondary_super_cache in server code

Signed-off-by: Ludovic Orban <lorban@bitronix.be>
@github-actions GitHub Actions
Copy link

This issue has been automatically marked as stale because it has been a
full year without activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@github-actions github-actions bot added the Stale For auto-closed stale issues and pull requests label Oct 25, 2024
@sbordet
Copy link
Contributor

sbordet commented Oct 25, 2024

Fixed by #10802.

@sbordet sbordet closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Performance Stale For auto-closed stale issues and pull requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sbordet @lorban @franz1981