-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Expect: 100-Continue
handling
#10956
Comments
Removed duplicate handling from servlet. Now only handled in core on first demand. Added additional tests.
@sbordet I asked the ietf http working group and was referred to RFC9113 8.1, which says:
So if the server sends a response (or commits the headers) before commencing reading of the request (and hence causing a 100 to be sent), then once the response is complete, we need to terminate the stream with a reset(NO_ERROR), to ensure the client does not hang waiting to send the request body. @lorban Apparently h3 is similar but a little different: https://datatracker.ietf.org/doc/html/rfc9114#section-4.1 It is plausible that this is the cause of the hangs in #10513, but I don't see how this was working in jetty-10? Perhaps we have just changed it enough to trigger this on a timing basis? or perhaps it is something else. |
@sbordet I'm thinking that we should do a reset(NO_ERROR) for H2 consumeAll? |
@gregw I agree on the reset after |
Removed duplicate handling from servlet. Now only handled in core in HttpChannelState and protected it from concurrent writes. Added additional tests. Signed-off-by: Simone Bordet <simone.bordet@gmail.com> Co-authored-by: Simone Bordet <simone.bordet@gmail.com>
Fixed by #10957. |
Expect: 100-Continue
handling
Jetty version(s)
12
Description
There is duplicate handling for
Expect: 100-Continue
in jetty-12.Also reports of hanging from #10513, so more testing is needed
The text was updated successfully, but these errors were encountered: