Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ServerWebSocketContainer to be created without ContextHandler #11356

Closed
lachlan-roberts opened this issue Jan 30, 2024 · 0 comments · Fixed by #11357
Closed

Allow ServerWebSocketContainer to be created without ContextHandler #11356

lachlan-roberts opened this issue Jan 30, 2024 · 0 comments · Fixed by #11357
Assignees
Labels
Bug For general bugs on Jetty side

Comments

@lachlan-roberts
Copy link
Contributor

Jetty version(s)
12.0.x

Description

ServerWebSocketContainer only has an ensure method which takes both Server and ContextHandler.
But in some cases people do not want to use ContextHandler.

Right now you can do WebSocketUpgradeHandler.from(jettyServer) which will create the ServerWebSocketContainer on the server without a ContextHandler. However if you do not want the WebSocketUpgradeHandler this is a waste. As you may wish to use the direct upgrade on ServerWebSocketContainer and not register any mappings on the WebSocketUpgradeHandler.

@lachlan-roberts lachlan-roberts added the Bug For general bugs on Jetty side label Jan 30, 2024
@lachlan-roberts lachlan-roberts self-assigned this Jan 30, 2024
lachlan-roberts added a commit that referenced this issue Jan 30, 2024
…ontextHandler

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit that referenced this issue Feb 14, 2024
…ainer-ensure

Issue #11356 - Allow ServerWebSocketContainer to be created without ContextHandler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Status: ✅ Done
1 participant