Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When producing URI/URL strings follow spec and produce lowercase schemes and drop default ports #11414

Closed
joakime opened this issue Feb 16, 2024 · 0 comments
Assignees
Labels
Bug For general bugs on Jetty side Specification For all industry Specifications (IETF / Servlet / etc)

Comments

@joakime
Copy link
Contributor

joakime commented Feb 16, 2024

Jetty version(s)
12.0.6

Jetty Environment
All

Java version/vendor (use: java -version)
Any

OS type/version
Any

Description
The URI spec says that we should accept form of case when we read a scheme, but should produce lowercase schemes.

The spec also says that the port is optional, and the scheme specific specs for HTTP and websocket says similar things.

URI Specs

HTTP/HTTPS scheme specific specs

Websocket scheme specific specs

We should strive to produce proper URIs where we can.

@joakime joakime added Bug For general bugs on Jetty side Specification For all industry Specifications (IETF / Servlet / etc) labels Feb 16, 2024
joakime added a commit that referenced this issue Feb 16, 2024
@joakime joakime self-assigned this Feb 16, 2024
@joakime joakime moved this to 🏗 In progress in Jetty 12.0.7 - FROZEN Feb 16, 2024
joakime added a commit that referenced this issue Feb 16, 2024
joakime added a commit that referenced this issue Feb 16, 2024
@gregw gregw closed this as completed in f07d812 Feb 20, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.7 - FROZEN Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side Specification For all industry Specifications (IETF / Servlet / etc)
Projects
No open projects
Status: ✅ Done
1 participant