NullPointerException in GzipEncoderSink, breaking all requests with CompressionHandler

[lambdaupb]

Jetty version(s)
12.1.2

Jetty Environment

HTTP version
HTTP/1 HTTP/2

Java version/vendor (use: java -version)
24

OS type/version

Description

jetty.project/jetty-core/jetty-compression/jetty-compression-gzip/src/main/java/org/eclipse/jetty/compression/gzip/internal/GzipEncoderSink.java

Line 146 in fd29d1d

if (content.hasRemaining())

content can be null, for example from here:

jetty.project/jetty-core/jetty-io/src/main/java/org/eclipse/jetty/io/content/ContentSinkOutputStream.java

Line 93 in fd29d1d

sink.write(true, null, callback);

[joakime]

Can you provide the complete stacktrace?

[lambdaupb]

java.lang.NullPointerException: Cannot invoke "java.nio.ByteBuffer.hasRemaining()" because "content" is null
  at org.eclipse.jetty.compression.gzip.internal.GzipEncoderSink.encode(GzipEncoderSink.java:141)
  at org.eclipse.jetty.compression.EncoderSink$EncodeBufferCallback.process(EncoderSink.java:85)
  at org.eclipse.jetty.util.IteratingCallback.processing(IteratingCallback.java:377)
  at org.eclipse.jetty.util.IteratingCallback.iterate(IteratingCallback.java:354)
  at org.eclipse.jetty.compression.EncoderSink.write(EncoderSink.java:39)
  at org.eclipse.jetty.compression.server.internal.CompressionResponse.write(CompressionResponse.java:143)
  at org.eclipse.jetty.io.content.ContentSinkOutputStream.close(ContentSinkOutputStream.java:93)
  at org.eclipse.jetty.io.content.ContentSinkOutputStream.close(ContentSinkOutputStream.java:82)
  at org.glassfish.jersey.message.internal.CommittingOutputStream.close(CommittingOutputStream.java:251)
  at org.glassfish.jersey.message.internal.OutboundMessageContext.close(OutboundMessageContext.java:569)
  at org.glassfish.jersey.server.ContainerResponse.close(ContainerResponse.java:406)
  at org.glassfish.jersey.server.ServerRuntime$Responder.writeResponse(ServerRuntime.java:763)
  at org.glassfish.jersey.server.ServerRuntime$Responder.processResponse(ServerRuntime.java:398)
  at org.glassfish.jersey.server.ServerRuntime$Responder.process(ServerRuntime.java:388)
  at org.glassfish.jersey.server.ServerRuntime$1.run(ServerRuntime.java:277)
  at org.glassfish.jersey.internal.Errors$1.call(Errors.java:248)
  at org.glassfish.jersey.internal.Errors$1.call(Errors.java:244)
  at org.glassfish.jersey.internal.Errors.process(Errors.java:292)
  at org.glassfish.jersey.internal.Errors.process(Errors.java:274)
  at org.glassfish.jersey.internal.Errors.process(Errors.java:244)
  at org.glassfish.jersey.process.internal.RequestScope.runInScope(RequestScope.java:266)
  at org.glassfish.jersey.server.ServerRuntime.process(ServerRuntime.java:253)
  at org.glassfish.jersey.server.ApplicationHandler.handle(ApplicationHandler.java:696)
  at org.glassfish.jersey.jetty.JettyHttpContainer.handle(JettyHttpContainer.java:164)
  at org.eclipse.jetty.compression.server.CompressionHandler.handle(CompressionHandler.java:348)
  at org.eclipse.jetty.server.Server.handle(Server.java:195)
  at org.eclipse.jetty.server.internal.HttpChannelState$HandlerInvoker.run(HttpChannelState.java:680)
  at org.eclipse.jetty.util.thread.Invocable$ReadyTask.run(Invocable.java:178)
  at org.eclipse.jetty.http2.server.internal.HttpStreamOverHTTP2$1.run(HttpStreamOverHTTP2.java:146)
  at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:1009)
  at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.doRunJob(QueuedThreadPool.java:1239)
  at org.eclipse.jetty.util.thread.QueuedThreadPool$Runner.run(QueuedThreadPool.java:1194)
  at java.base/java.lang.Thread.run(Thread.java:1474)

[joakime]

Thanks for that stacktrace.

We are looking at two things because of this filed issue.

1. why are we sending a null ByteBuffer and not an empty one (like we do in 90%+ of cases like this)
2. why is GzipEncoderSink not handling null ByteBuffer properly.

[joakime]

Opened PR

• Issue #13812 - NPE from CompressionHandler when using Content.Sink.asOutputStream #13835