Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GCThreadLeakPreventer won't work with Java 9 #1923

Closed
jnehlmeier opened this issue Oct 27, 2017 · 5 comments · Fixed by #5724
Closed

GCThreadLeakPreventer won't work with Java 9 #1923

jnehlmeier opened this issue Oct 27, 2017 · 5 comments · Fixed by #5724
Labels
Enhancement Help Wanted

Comments

@jnehlmeier
Copy link

In Java 9 the class sun.misc.GC has been moved to sun.rmi.transport.GC making GCThreadLeakPreventer non functional.

https://bugs.openjdk.java.net/browse/JDK-8153286
@sbordet
Copy link
Contributor

sbordet commented Oct 27, 2017

Thanks ! Care to submit a patch that works with JDK 9 ? See http://www.eclipse.org/jetty/documentation/9.4.x/contributing-patches.html.

@tbroyer
Copy link

tbroyer commented Oct 27, 2017

Not sure there's anything to do here: https://bugs.openjdk.java.net/browse/JDK-8157570

@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@sbordet
Copy link
Contributor

sbordet commented Nov 20, 2019

We need to review those preventers and possibly put them in a different Jetty 10 module so that we can have a specific module-info.java without polluting the jetty-util one.

@stale stale bot removed the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@stale
Copy link

stale bot commented Nov 24, 2020

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 24, 2020
sbordet added a commit that referenced this issue Nov 24, 2020
@sbordet
Fixes #1923 - GCThreadLeakPreventer won't work with Java 9.
96e0685 
GCThreadLeakPreventer has been removed, since the issue
it was trying to fix was solved in Java 9+.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet linked a pull request Nov 24, 2020 that will close this issue
Fixes #1923 - GCThreadLeakPreventer won't work with Java 9. #5724
Merged
@sbordet sbordet removed the Stale For auto-closed stale issues and pull requests label Nov 24, 2020
@sbordet sbordet mentioned this issue Nov 24, 2020
Closed
sbordet added a commit that referenced this issue Nov 24, 2020
@sbordet
Merge pull request #5724 from eclipse/jetty-10.0.x-1923-remove_gcleak…
9fb9b23 
…preventer

Fixes #1923 - GCThreadLeakPreventer won't work with Java 9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Help Wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #1923 - GCThreadLeakPreventer won't work with Java 9. jetty/jetty.project
3 participants
@tbroyer @sbordet @jnehlmeier