Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating MultiException #2075

Closed
sbordet opened this issue Dec 20, 2017 · 1 comment
Closed

Deprecating MultiException #2075

sbordet opened this issue Dec 20, 2017 · 1 comment

Comments

@sbordet
Copy link
Contributor

sbordet commented Dec 20, 2017

Now that every Throwable can have suppressed Throwables, is there a reason to keep MultiException around ?

@gregw
Copy link
Contributor

gregw commented Dec 21, 2017

I think the class is still needed. At the very least it provides useful/readable utility methods to make it clear that multiple exceptions are expected and that they are being aggregated.

But I also think there is a difference between and exception with suppressed exceptions, which can mean there was an exception and other things were thrown while handling it, vs a MultiException that indicates multiple probably independent failures occurred and one of them does not suppress the others.

However, I do think that we can perhaps update the class and remove it's own internal array list and just use the suppressed list.

gregw added a commit that referenced this issue Jan 8, 2018
Signed-off-by: Greg Wilkins <gregw@webtide.com>
gregw added a commit that referenced this issue Jan 23, 2018
* Issue #2075 cleanup multiexceptio to better use suppressed
* Update MultiException.java fixes from review
Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw closed this as completed Jan 23, 2018
gregw added a commit that referenced this issue Jun 7, 2018
* Issue #2075 cleanup multiexceptio to better use suppressed
* Update MultiException.java fixes from review
Signed-off-by: Greg Wilkins <gregw@webtide.com>
@joakime joakime changed the title Consider deprecating/removing MultiException Deprecating MultiException Jul 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants