Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch SslContextFactory.keystoreType from JKS to PKCS12 #2643

Closed
joakime opened this issue Jun 8, 2018 · 3 comments · Fixed by #4489
Closed

Switch SslContextFactory.keystoreType from JKS to PKCS12 #2643

joakime opened this issue Jun 8, 2018 · 3 comments · Fixed by #4489

Comments

@joakime
Copy link
Contributor

joakime commented Jun 8, 2018

Since the default implementation in Java is now PKCS12, perhaps with Jetty 10 we should switch our defaults over to PKCS12 as well, retiring the JKS default in SslContextFactory.
@stale
Copy link

stale bot commented Nov 20, 2019

This issue has been automatically marked as stale because it has been a full year without activit. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@joakime
Copy link
Contributor Author

joakime commented Nov 20, 2019

@sbordet do we still want to do this for Jetty 10?

@stale stale bot removed the Stale For auto-closed stale issues and pull requests label Nov 20, 2019
@sbordet
Copy link
Contributor

sbordet commented Nov 20, 2019

Yes we want to do it for 10.

@sbordet sbordet changed the title Switch SslContextFactory default from JKS to PKCS12 for Jetty 10? Switch SslContextFactory.keystoreType from JKS to PKCS12 Jan 17, 2020
sbordet added a commit that referenced this issue Jan 17, 2020
@sbordet
Fixes #2643 - Switch SslContextFactory.keystoreType from JKS to PKCS12.
d60b445 
Updated old keystores to new PKCS12 keystores.
Removed unused keystores and truststores.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet mentioned this issue Jan 17, 2020
Merged
sbordet added a commit that referenced this issue Jan 30, 2020
@sbordet
Merge pull request #4489 from eclipse/jetty-10.0.x-2643-pkcs12_keystores
ce6e146 
Fixes #2643 - Switch SslContextFactory.keystoreType from JKS to PKCS12.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2643 - Switch SslContextFactory.keystoreType from JKS to PKCS12. jetty/jetty.project
2 participants
@joakime @sbordet