Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove B64Code #2909

Closed
sbordet opened this issue Sep 14, 2018 · 4 comments
Closed

Remove B64Code #2909

sbordet opened this issue Sep 14, 2018 · 4 comments
Assignees
@lachlan-roberts
Labels
Help Wanted Low Priority

Comments

@sbordet
Copy link
Contributor

sbordet commented Sep 14, 2018

The ancient B64Code class in jetty-util should be replaced by JDK 8's Base64 class, which is more up-to-date with base64 RFCs and not maintained by us.
@gregw
Copy link
Contributor

gregw commented Sep 16, 2018

+1... except we have to be absolutely sure that any changed usages don't depend on the older/different BASE64 interpretations.

joakime added a commit that referenced this issue May 9, 2019
@joakime
Issue #2909 - Replace B64Code with java.util.Base64
1c2919a 
+ Deprecated B64Code
+ All code that isn't B64CodeTest is now using java.util.Base64
+ B64CodeTest is updated to confirm change to java.util.Base64
  is possible without change in behavior. Just have to make
  sure you use the appropriate Encoder / Decoder for the task
  at hand (default vs mime vs url)

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime
Copy link
Contributor

joakime commented May 9, 2019

Opened PR #3640

joakime added a commit that referenced this issue May 9, 2019
@joakime
Issue #2909 - Replace B64Code with java.util.Base64
5f80850 
+ Address Mime Encoding behavior difference detected in testcase

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime added a commit that referenced this issue May 14, 2019
@joakime
Issue #2909 - adding jmh tests
adb30f0 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
gregw pushed a commit that referenced this issue May 15, 2019
@joakime @gregw
Issue #2909 - Replace B64Code with java.util.Base64
b44ecc9 
+ Deprecated B64Code
+ All code that isn't B64CodeTest is now using java.util.Base64
+ B64CodeTest is updated to confirm change to java.util.Base64
  is possible without change in behavior. Just have to make
  sure you use the appropriate Encoder / Decoder for the task
  at hand (default vs mime vs url)

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
gregw pushed a commit that referenced this issue May 15, 2019
@joakime @gregw
Issue #2909 - Replace B64Code with java.util.Base64
73d7eaa 
+ Address Mime Encoding behavior difference detected in testcase

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
gregw pushed a commit that referenced this issue May 15, 2019
@joakime @gregw
Issue #2909 - adding jmh tests
076c6b1 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime mentioned this issue May 15, 2019
Merged
@gregw
Copy link
Contributor

gregw commented May 15, 2019

I have merged @joakime 's PR #3640
@lachlan-roberts can you do another for using java.util.Base64.Decoder#wrap(InputStream) in MultiPartInputStreamParser

@lachlan-roberts
Copy link
Contributor

@gregw I don't think you can just do this to replace the Base64InputStream class. The InputStream used has the content as base64 but the part boundary as plain text.

The MultiPartInputStreamParser class has been deprecated and the Content-Transfer-Encoding has also been deprecated from RFC7578. So it is probably not worth spending much effort trying to improve the performance of this.

@gregw gregw closed this as completed Jun 5, 2019
joakime added a commit that referenced this issue Jun 20, 2019
@joakime
Issue #2909 - Remove B64Code
ef36cde 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lachlan-roberts lachlan-roberts

Labels
Help Wanted Low Priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gregw @joakime @sbordet @lachlan-roberts