Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 10 Configuration replacement algorithm incorrect #2985

Closed
janbartel opened this issue Oct 16, 2018 · 1 comment
Closed

Jetty 10 Configuration replacement algorithm incorrect #2985

janbartel opened this issue Oct 16, 2018 · 1 comment
Assignees
@janbartel
Milestone
10.0.x

Comments

@janbartel
Copy link
Contributor

Configurations.addConfiguration() method does not properly consider Configurations with replacements. If B is a replacement for A, yet B is added to the configuration list first, when A is added, it should be skipped because B replaces it.
@janbartel janbartel added this to the 10.0.x milestone Oct 16, 2018
@janbartel janbartel self-assigned this Oct 16, 2018
janbartel added a commit that referenced this issue Oct 16, 2018
@janbartel
Issue #2985 Configuration replacement algorithm
efd4001 
Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel mentioned this issue Oct 16, 2018
Merged
janbartel added a commit that referenced this issue Oct 16, 2018
@janbartel
Issue #2985 requested changes from review
1312719 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Oct 17, 2018
@janbartel
Issue #2985 further changes requested in pr
b4c75ec 
Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Oct 17, 2018
@janbartel
Issue #2985 Configuration replacement algorithm (#2987)
2bb8902 
* Issue #2985 Configuration replacement algorithm

Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this issue Oct 17, 2018
@janbartel
Issue #2985 Clean configs after each test
6c809fe
@janbartel
Copy link
Contributor Author

Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janbartel janbartel

Labels
None yet
Projects
None yet
Milestone
10.0.x
Development

No branches or pull requests
1 participant
@janbartel