-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle-RequiredExecutionEnvironment: JavaSE-11 for Jetty 10.0.x #3185
Comments
Eclipse Equinox added support for |
If we can find the appropriate artifact on maven central. Currently we have: <groupId>org.eclipse.platform</groupId>
<artifactId>org.eclipse.osgi</artifactId>
<version>3.13.100</version> |
I tried changing the Required-Execution-Environment header in our osgi manifests to JavaSE-11, and ran the osgi unit tests. They actually worked with no errors. Somewhat confusing since release 3.13.100 from maven central predates any of the eclipse bugs that mention support for jdk-11. @guw any advice? |
@janbartel Do you have a pointer to the OSGi unit tests? Happy to take a look. |
Hi Gunnar, The osgi unit tests are here: https://github.com/eclipse/jetty.project/tree/jetty-10.0.x/jetty-osgi/test-jetty-osgi To update to JavaSE-11, I changed this line in the jetty project's top level pom and rebuilt: https://github.com/eclipse/jetty.project/blob/jetty-10.0.x/pom.xml#L660 |
Are you running the Maven build with JDK 11 or are you using a toolchain.xml? I suspect that the tests will be executed with the Java running the build. Frankly, I don't know if Equinox needed special support for Java 11 execution environment. Most of the bugs I found are related to JDT and Java Development. We have a couple of JDK 11 issues with missing imports because of javax.xml stuff that has been removed. |
@guw I'm running with jdk 11. Our pom also enforces use of jdk 11. So other users deploying into OSGi at the command line shouldn't experience any BREE problems if they just use jdk 11? |
No they shouldn't. Only if they run on a lower JDK. |
This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions. |
…y 10.0.x. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
…_environment_java11 Fixes #3185 - Bundle-RequiredExecutionEnvironment: JavaSE-11 for Jett…
Should we upgrade our OSGi manifests to be
Now that Jetty 10.x will be Java 11+ minimum JVM requirement?
The text was updated successfully, but these errors were encountered: