Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review jetty-10 websocket CompletableFuture usage. #3298

Closed
gregw opened this issue Jan 29, 2019 · 0 comments
Closed

Review jetty-10 websocket CompletableFuture usage. #3298

gregw opened this issue Jan 29, 2019 · 0 comments

Comments

@gregw
Copy link
Contributor

gregw commented Jan 29, 2019

The UpgradeRequest hierarchy in the websocket client has multiple CompletableFutures. Review if they are all necessary, if they are correctly contained and if they are all succeeded/failed correctly.
See discussion on #3291
@gregw gregw mentioned this issue Jan 29, 2019
Merged
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Jan 30, 2019
@lachlan-roberts
Issue jetty#3298 - Refactor of upgrade request class names
b4bd598 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Jan 31, 2019
@lachlan-roberts
Issue jetty#3298 - cleanup of CompletableFutures for WebSocket upgrades
bd4f9b3 
Jetty and Javax ClientUpgradeRequests no longer use the combination of
the the onOpenFuture and the futureCoreSession and instead use only
the CompletableFuture future given to the FrameHandler onOpen

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Jan 31, 2019
@lachlan-roberts
Issue jetty#3298 - bug fixes for jetty websockets
3abf335 
succeed callback when you do not have a message sink

OnWebSocketFrame annotation should take an API frame not a core frame

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this issue Jan 31, 2019
Merged
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Jan 31, 2019
@lachlan-roberts
Issue jetty#3298 - bug fixes for jetty websockets
6a98cc0 
succeed callback when you do not have a message sink

OnWebSocketFrame annotation should take an API frame not a core frame

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 4, 2019
@lachlan-roberts
Issue jetty#3298 - fix to pom file
77b7e27 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts added a commit to lachlan-roberts/jetty.project that referenced this issue Feb 4, 2019
@lachlan-roberts
Issue jetty#3298 - rename typo in JettyWebSocketTest name
bfcb890 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw added a commit that referenced this issue Feb 4, 2019
@gregw
Merge pull request #3310 from lachlan-roberts/jetty-10.0.x-3298-compl…
a41f270 
…etableFutures

Issue #3298 - WebSocket UpgradeRequests and CompletableFutures
@gregw gregw closed this as completed Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregw