Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review Jetty 10 module-info.java #3320

Closed
sbordet opened this issue Feb 4, 2019 · 0 comments
Closed

Review Jetty 10 module-info.java #3320

sbordet opened this issue Feb 4, 2019 · 0 comments
Milestone
10.0.x

Comments

@sbordet
Copy link
Contributor

sbordet commented Feb 4, 2019

module-info.java files are there for Jetty 10.

We need to review them to make sure that the dependencies are correct (e.g. that requires static or require transitive are correct).
Order packages in alphabetical order.
sbordet added a commit that referenced this issue Feb 8, 2019
@sbordet
Fixes #3320 - Review Jetty 10 module-info.java.
b9f89af 
Reviewed module-info.java files.
For those that have a "requires static" added a comment about
why the dependency is optional.
Rearranged directives in alphabetical order.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet mentioned this issue Feb 8, 2019
Merged
@sbordet sbordet added this to the 10.0.x milestone Feb 12, 2019
sbordet added a commit that referenced this issue Feb 12, 2019
@sbordet
Fixes #3320 - Review Jetty 10 module-info.java.
ae207bd 
After review, keeping "requires static" only if the
module tree can be built without the static module.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
sbordet added a commit that referenced this issue Feb 12, 2019
@sbordet
Merge pull request #3342 from eclipse/jetty-10.0.x-3320-review_module…
477d7cf 
…_info

Fixes #3320 - Review Jetty 10 module-info.java.
@sbordet sbordet closed this as completed Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
10.0.x
Development

No branches or pull requests
1 participant
@sbordet